fix(config): Add sample data visibility env flag#778
Conversation
Configures the initial visibility state at build time. Can prevent a benign race condition between the default (true) and runtime-fetched (false) settings where delayed state update looks ugly.
✅ Deploy Preview for volview-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
lets remove the non working |
I thought we still wanted the ability to override the |
I guess I missed that requirment. I don't think that is needed. 2 places to config the same thing? There is an opprotunity to have a negative line count commit, which makes me happy. |
|
I can see the argument for removing the configJson code that handles sample data visibility. Users likely won't care to configure it at runtime, and instead only care about having an app that either shows it (unlikely) or doesn't show it (likely). Scratch the overriding idea. Let's just remove it entirely from the configJson code. |
|
You'll need to add |
|
also need to add that env var to the netlify.tomal file |
github-merge-queue
Bot
closed this pull request by merging all changes
into
Kitware:main
in
7f6def4
3 participants
Closes #759
Configures the initial visibility state at build time. Can prevent a benign race condition between the default (true) and runtime-fetched (false) settings where delayed state update looks ugly.